Correct batch publishing function name in README.md #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README references a `publish_batch` function. I couldn't get that to work; digging through the source, it looks like it intends to refer to the `batch_publish` function: https://github.com/nicholassm/disruptor-rs/blob/22e13239eddf5f6695238dbde8d6121059dfeb69/src/producer.rs#L218
|
Many thanks. |
nicholassm
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cool library!
I was trying to experiment with it locally, using the examples in the README to get started, but I couldn't get batch publishing to work.
It looks like while the README references
publish_batch, the actual function for the producer isbatch_publish.disruptor-rs/src/producer.rs
Line 218 in 22e1323