Fix ingress definition to include tensorboard port

nicklausbrown · Apr 20, 2024 · 9abebc0 · 9abebc0
1 parent 6f10337
commit 9abebc0
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 4 deletions.
diff --git a/charts/jupyter/Chart.yaml b/charts/jupyter/Chart.yaml
@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.4.3
+version: 0.4.4
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

diff --git a/charts/jupyter/templates/ingress.yaml b/charts/jupyter/templates/ingress.yaml
@@ -51,7 +51,7 @@ spec:
               service:
                 name: {{ $fullName }}
                 port:
-                  number: {{ $svcPort }}
+                  number: {{ default $svcPort .svcPort }}
               {{- else }}
               serviceName: {{ $fullName }}
               servicePort: {{ $svcPort }}

diff --git a/charts/jupyter/values.yaml b/charts/jupyter/values.yaml
@@ -51,6 +51,7 @@ ingress:
       paths:
         - path: /
           pathType: ImplementationSpecific
+          svcPort: 8888
   tls: []
   #  - secretName: chart-example-tls
   #    hosts:

diff --git a/jupyter-treus/Chart.yaml b/jupyter-treus/Chart.yaml
@@ -25,5 +25,5 @@ appVersion: "1.0.0"
 
 dependencies:
 - name: jupyter
-  version: 0.4.3
+  version: 0.4.4
   repository: https://nicklausbrown.github.io/jupyter-kubernetes/
diff --git a/jupyter-treus/values.yaml b/jupyter-treus/values.yaml
@@ -28,7 +28,6 @@ jupyter:
         paths:
           - path: /
             pathType: ImplementationSpecific
-            svcPort: 8888
           - path: /tensorboard
             pathType: ImplementationSpecific
             svcPort: 6006