Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-symbol handling and prevent day trading #23

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Flawlesssharky6
Copy link

You can now trade as many symbols as you want by adding or removing the symbols to the list "symbols". Ensure you are doing that on lines 111 and 121 (you should change it on line 26 to be safe but it doesn't matter).

You can also change self.sleeptime to whatever you want and not worry about day trading. My testing found that 24H is still one of the better general self.sleeptime, but knowing you can't day trade is still nice. If you want to day trade you can just comment out lines 68-72, 88, and 102 (the most important lines are 70-72).

@Flawlesssharky6
Copy link
Author

I am trying to add another strategy to synergize with the sentiment one that is currently in use because I feel like the results can be improved (ex: the max drop downs). I am currently trying to use trend following with adaptive position sizing (so far it seems too strict to make trades and significantly improve results) and breakouts (working out some kinks and I'm not sure if it will significantly improve the results). I am still working on these but does anyone have some tips?

@Flawlesssharky6
Copy link
Author

Flawlesssharky6 commented Aug 10, 2024

I just added a program to check for day trades (I just imported a project on my repository as a folder into this project). I am confident that the program will work. But if the time conversions fail the trades are extracted and logged for you to review.

I'm unfamiliar with licenses but I added one so I don't get in trouble. But if you encounter problems, please contact me or leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant