feat: add customizable terminators #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaiunrein
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Thanks for this neat PR and for the overall cleanup. It is unfortunate that the delimiter does not accept Nul as an argument otherwise we could re-use it's implementation. I think we should leave it like it is for now. I am happy to merge once the two small changes are implemented.
Whiel using `cargo-get` in scripts, it is often useful to be able to change the ending character of the output -- ensuring that a newline does *not* get printed, adding a NUL terminator, etc. This commit adds an option `--terminator` which changes the terminator that is printed after the requested output from `cargo-get`. Signed-off-by: vados <[email protected]>
nicolaiunrein
approved these changes
Oct 30, 2023
|
Thanks again for the awesome project and quick reviews/and help, going to be nice to take out the TODO comment in my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whiel using
cargo-getin scripts, it is often useful to be able to change the ending character of the output -- ensuring that a newline does not get printed, adding a NUL terminator, etc.This commit adds an option
--terminatorwhich changes the terminator that is printed after the requested output fromcargo-get.Resolves #14