Skip to content

Commit

Permalink
Revert "Enhance Glances browser color (issue #977)"
Browse files Browse the repository at this point in the history
This reverts commit efaadb4.
  • Loading branch information
nicolargo committed May 8, 2017
1 parent efaadb4 commit 44f24f6
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 37 deletions.
4 changes: 0 additions & 4 deletions glances/client_browser.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,11 +114,8 @@ def __update_stats(self, server):
# CPU%
cpu_percent = 100 - json.loads(s.getCpu())['idle']
server['cpu_percent'] = '{:.1f}'.format(cpu_percent)
# !!! Not correct because we have to look system and iowait too...
server['cpu_percent_views'] = json.loads(s.getViewsCpu())['user']['decoration']
# MEM%
server['mem_percent'] = json.loads(s.getMem())['percent']
server['mem_percent_views'] = json.loads(s.getViewsMem())['used']['decoration']
# OS (Human Readable name)
server['hr_name'] = json.loads(s.getSystem())['hr_name']
except (socket.error, Fault, KeyError) as e:
Expand All @@ -143,7 +140,6 @@ def __update_stats(self, server):
# LOAD
load_min5 = json.loads(s.getLoad())['min5']
server['load_min5'] = '{:.2f}'.format(load_min5)
server['load_percent_views'] = json.loads(s.getViewsLoad())['min5']['decoration']
except Exception as e:
logger.warning(
"Error while grabbing stats form {}: {}".format(uri, e))
Expand Down
24 changes: 10 additions & 14 deletions glances/outputs/glances_curses_browser.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,17 +197,17 @@ def display(self, servers_list):
# ================================

# Table of table
# Item description: [stats_id, column name, column size, status_key]
# Item description: [stats_id, column name, column size]
column_def = [
['name', 'Name', 16, 'status'],
['alias', None, None, 'status'],
['load_min5', 'LOAD', 6, 'status'],
['cpu_percent', 'CPU%', 5, 'cpu_percent_views'],
['mem_percent', 'MEM%', 5, 'mem_percent_views'],
['status', 'STATUS', 9, 'status'],
['ip', 'IP', 15, 'status'],
['name', 'Name', 16],
['alias', None, None],
['load_min5', 'LOAD', 6],
['cpu_percent', 'CPU%', 5],
['mem_percent', 'MEM%', 5],
['status', 'STATUS', 9],
['ip', 'IP', 15],
# ['port', 'PORT', 5],
['hr_name', 'OS', 16, 'status'],
['hr_name', 'OS', 16],
]
y = 2

Expand Down Expand Up @@ -261,13 +261,9 @@ def display(self, servers_list):
xc += 2
for c in column_def:
if xc < screen_x and y < screen_y and c[1] is not None:
# Get the status key in the list
status = c[3]
if status not in v or v['status'] == 'OFFLINE':
status = 'status'
# Display server stats
self.term_window.addnstr(
y, xc, format(server_stat[c[0]]), c[2], self.colors_list[v[status]])
y, xc, format(server_stat[c[0]]), c[2], self.colors_list[v['status']])
xc += c[2] + self.space_between_column
cpt += 1
# Next line, next server...
Expand Down
10 changes: 4 additions & 6 deletions glances/plugins/glances_plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -447,17 +447,15 @@ def get_views(self, item=None, key=None, option=None):
item_views = self.views[item]

if key is None:
ret = item_views
return item_views
else:
if option is None:
ret = item_views[key]
return item_views[key]
else:
if option in item_views[key]:
ret = item_views[key][option]
return item_views[key][option]
else:
ret = 'DEFAULT'

return self._json_dumps(ret)
return 'DEFAULT'

def load_limits(self, config):
"""Load limits from the configuration file, if it exists."""
Expand Down
1 change: 1 addition & 0 deletions glances/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ def serve_forever(self):
"""Main loop"""
while not self.finished:
self.handle_request()
logger.info(self.finished)


class GlancesInstance(object):
Expand Down
14 changes: 1 addition & 13 deletions glances/stats.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,21 +54,9 @@ def __getattr__(self, item):
The goal is to dynamically generate the following methods:
- getPlugname(): return Plugname stat in JSON format
- getViewsPlugname(): return views of the Plugname stat in JSON format
"""
# Check if the attribute starts with 'get'
if item.startswith('getViews'):
# Get the plugin name
plugname = item[len('getViews'):].lower()
# Get the plugin instance
plugin = self._plugins[plugname]
if hasattr(plugin, 'get_views'):
# The method get_views exist, return it
return getattr(plugin, 'get_views')
else:
# The method get_views is not found for the plugin
raise AttributeError(item)
elif item.startswith('get'):
if item.startswith('get'):
# Get the plugin name
plugname = item[len('get'):].lower()
# Get the plugin instance
Expand Down

0 comments on commit 44f24f6

Please sign in to comment.