Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing mobile popup text size so it's readable #45

Merged
merged 1 commit into from
Aug 27, 2018
Merged

Changing mobile popup text size so it's readable #45

merged 1 commit into from
Aug 27, 2018

Conversation

JamsheedMistri
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Aug 26, 2018

Codecov Report

Merging #45 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files          28       28           
  Lines         616      616           
  Branches       85       85           
=======================================
  Hits          555      555           
  Misses         34       34           
  Partials       27       27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 381eee3...e0ec0b2. Read the comment docs.

@nicolaschan nicolaschan changed the base branch from master to dev August 27, 2018 06:53
@nicolaschan nicolaschan changed the base branch from dev to master August 27, 2018 06:58
@nicolaschan nicolaschan changed the base branch from master to dev August 27, 2018 06:58
@nicolaschan nicolaschan changed the base branch from dev to master August 27, 2018 17:17
Copy link
Owner

@nicolaschan nicolaschan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit concerned about size when horizontal on mobile, but it's probably fine until we figure out something better.

@nicolaschan nicolaschan merged commit 6a10b1a into nicolaschan:master Aug 27, 2018
@nicolaschan
Copy link
Owner

Slightly fixes #41 but better mobile support in the future is desired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants