Update pan and zoom in camera verification #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verification methods seem not to work. New verification by object type added. Fixing issue found when using the library in Angular7.
MichalHe
reviewed
Mar 6, 2019
There was a problem hiding this comment.
Hi,
thanks for pointing this out and fixing it. I would suggest moving the changes into the typeguard functions (_checkOrthographicCamera etc.). This way it is easier to keep the logic behind camera's type determination in one place (allows easier changes) and it also prevents code duplication.
Also it seems that you've changed only the index.js file, which is only the transpiled version of index.ts (actual source).
|
Hello MichalHe, Ok!! Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification methods seem not to work. New verification by object type added.
Fixing issue found when using the library in Angular7.