forked from babel/babel
-
-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[babel 8] Move ESLint parsing to a Worker (babel#13199)
- Loading branch information
1 parent
c218134
commit 9d620c2
Showing
32 changed files
with
610 additions
and
330 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| const path = require("path"); | ||
|
|
||
| let send; | ||
|
|
||
| exports.getVersion = sendCached("GET_VERSION"); | ||
|
|
||
| exports.getTypesInfo = sendCached("GET_TYPES_INFO"); | ||
|
|
||
| exports.getVisitorKeys = sendCached("GET_VISITOR_KEYS"); | ||
|
|
||
| exports.getTokLabels = sendCached("GET_TOKEN_LABELS"); | ||
|
|
||
| exports.maybeParse = (code, options) => send("MAYBE_PARSE", { code, options }); | ||
|
|
||
| function sendCached(action) { | ||
| let cache = null; | ||
|
|
||
| return () => { | ||
| if (!cache) cache = send(action, undefined); | ||
| return cache; | ||
| }; | ||
| } | ||
|
|
||
| if (process.env.BABEL_8_BREAKING) { | ||
| const { | ||
| Worker, | ||
| receiveMessageOnPort, | ||
| MessageChannel, | ||
| SHARE_ENV, | ||
| } = require("worker_threads"); | ||
|
|
||
| // We need to run Babel in a worker for two reasons: | ||
| // 1. ESLint workers must be CJS files, and this is a problem | ||
| // since Babel 8+ uses native ESM | ||
| // 2. ESLint parsers must run synchronously, but many steps | ||
| // of Babel's config loading (which is done for each file) | ||
| // can be asynchronous | ||
| // If ESLint starts supporting async parsers, we can move | ||
| // everything back to the main thread. | ||
| const worker = new Worker( | ||
| path.resolve(__dirname, "../lib/worker/index.cjs"), | ||
| { env: SHARE_ENV }, | ||
| ); | ||
|
|
||
| // The worker will never exit by itself. Prevent it from keeping | ||
| // the main process alive. | ||
| worker.unref(); | ||
|
|
||
| const signal = new Int32Array(new SharedArrayBuffer(4)); | ||
|
|
||
| send = (action, payload) => { | ||
| signal[0] = 0; | ||
| const subChannel = new MessageChannel(); | ||
|
|
||
| worker.postMessage({ signal, port: subChannel.port1, action, payload }, [ | ||
| subChannel.port1, | ||
| ]); | ||
|
|
||
| Atomics.wait(signal, 0, 0); | ||
| const { message } = receiveMessageOnPort(subChannel.port2); | ||
|
|
||
| if (message.error) throw Object.assign(message.error, message.errorData); | ||
| else return message.result; | ||
| }; | ||
| } else { | ||
| send = require("./worker/index.cjs"); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| exports.normalizeESLintConfig = function (options) { | ||
| const { | ||
| babelOptions = {}, | ||
| // ESLint sets ecmaVersion: undefined when ecmaVersion is not set in the config. | ||
| ecmaVersion = 2020, | ||
| sourceType = "module", | ||
| allowImportExportEverywhere = false, | ||
| requireConfigFile = true, | ||
| ...otherOptions | ||
| } = options; | ||
|
|
||
| return { | ||
| babelOptions, | ||
| ecmaVersion, | ||
| sourceType, | ||
| allowImportExportEverywhere, | ||
| requireConfigFile, | ||
| ...otherOptions, | ||
| }; | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| function* it(children) { | ||
| if (Array.isArray(children)) yield* children; | ||
| else yield children; | ||
| } | ||
|
|
||
| function traverse(node, visitorKeys, visitor) { | ||
| const { type } = node; | ||
| if (!type) return; | ||
| const keys = visitorKeys[type]; | ||
| if (!keys) return; | ||
|
|
||
| for (const key of keys) { | ||
| for (const child of it(node[key])) { | ||
| if (child && typeof child === "object") { | ||
| visitor.enter(child); | ||
| traverse(child, visitorKeys, visitor); | ||
| visitor.exit(child); | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| const convertNodesVisitor = { | ||
| enter(node) { | ||
| if (node.innerComments) { | ||
| delete node.innerComments; | ||
| } | ||
|
|
||
| if (node.trailingComments) { | ||
| delete node.trailingComments; | ||
| } | ||
|
|
||
| if (node.leadingComments) { | ||
| delete node.leadingComments; | ||
| } | ||
| }, | ||
| exit(node) { | ||
| // Used internally by @babel/parser. | ||
| if (node.extra) { | ||
| delete node.extra; | ||
| } | ||
|
|
||
| if (node?.loc.identifierName) { | ||
| delete node.loc.identifierName; | ||
| } | ||
|
|
||
| if (node.type === "TypeParameter") { | ||
| node.type = "Identifier"; | ||
| node.typeAnnotation = node.bound; | ||
| delete node.bound; | ||
| } | ||
|
|
||
| // flow: prevent "no-undef" | ||
| // for "Component" in: "let x: React.Component" | ||
| if (node.type === "QualifiedTypeIdentifier") { | ||
| delete node.id; | ||
| } | ||
| // for "b" in: "var a: { b: Foo }" | ||
| if (node.type === "ObjectTypeProperty") { | ||
| delete node.key; | ||
| } | ||
| // for "indexer" in: "var a: {[indexer: string]: number}" | ||
| if (node.type === "ObjectTypeIndexer") { | ||
| delete node.id; | ||
| } | ||
| // for "param" in: "var a: { func(param: Foo): Bar };" | ||
| if (node.type === "FunctionTypeParam") { | ||
| delete node.name; | ||
| } | ||
|
|
||
| // modules | ||
| if (node.type === "ImportDeclaration") { | ||
| delete node.isType; | ||
| } | ||
|
|
||
| // template string range fixes | ||
| if (node.type === "TemplateLiteral") { | ||
| for (let i = 0; i < node.quasis.length; i++) { | ||
| const q = node.quasis[i]; | ||
| q.range[0] -= 1; | ||
| if (q.tail) { | ||
| q.range[1] += 1; | ||
| } else { | ||
| q.range[1] += 2; | ||
| } | ||
| q.loc.start.column -= 1; | ||
| if (q.tail) { | ||
| q.loc.end.column += 1; | ||
| } else { | ||
| q.loc.end.column += 2; | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| }; | ||
|
|
||
| function convertNodes(ast, visitorKeys) { | ||
| traverse(ast, visitorKeys, convertNodesVisitor); | ||
| } | ||
|
|
||
| function convertProgramNode(ast) { | ||
| ast.type = "Program"; | ||
| ast.sourceType = ast.program.sourceType; | ||
| ast.body = ast.program.body; | ||
| delete ast.program; | ||
| delete ast.errors; | ||
|
|
||
| if (ast.comments.length) { | ||
| const lastComment = ast.comments[ast.comments.length - 1]; | ||
|
|
||
| if (ast.tokens.length) { | ||
| const lastToken = ast.tokens[ast.tokens.length - 1]; | ||
|
|
||
| if (lastComment.end > lastToken.end) { | ||
| // If there is a comment after the last token, the program ends at the | ||
| // last token and not the comment | ||
| ast.range[1] = lastToken.end; | ||
| ast.loc.end.line = lastToken.loc.end.line; | ||
| ast.loc.end.column = lastToken.loc.end.column; | ||
| } | ||
| } | ||
| } else { | ||
| if (!ast.tokens.length) { | ||
| ast.loc.start.line = 1; | ||
| ast.loc.end.line = 1; | ||
| } | ||
| } | ||
|
|
||
| if (ast.body && ast.body.length > 0) { | ||
| ast.loc.start.line = ast.body[0].loc.start.line; | ||
| ast.range[0] = ast.body[0].start; | ||
| } | ||
| } | ||
|
|
||
| module.exports = function convertAST(ast, visitorKeys) { | ||
| convertNodes(ast, visitorKeys); | ||
| convertProgramNode(ast); | ||
| }; |
Oops, something went wrong.