Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Jwt middleware is only run once #126

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Ensure Jwt middleware is only run once #126

wants to merge 3 commits into from

Conversation

jsikkes
Copy link

@jsikkes jsikkes commented Feb 4, 2025

Issue Link

#125

Types of changes

  • Bug fix
  • New feature

Description

Instead of using the "rest_endpoints" Wordpress hook for authorization middleware use the "rest_authentication_errors" filters hook which only runs once per request.

How has this been tested?

  • Tracing of the rest-api request code execution path.
  • Analysis of HTTP Response headers, of version 3.5.7 and development version
  • Run tests according to the contribution guide

Checklist:

  • My code is tested.
  • I wrote tests for the impacted area
  • I ran composer check-plugin locally

@jsikkes jsikkes mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jsikkes