fix some sonarscan issues

nightscout · Nov 1, 2024 · 33754c9 · 33754c9
1 parent 4e2b327
commit 33754c9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/core/objects/src/main/kotlin/app/aaps/core/objects/wizard/BolusWizard.kt b/core/objects/src/main/kotlin/app/aaps/core/objects/wizard/BolusWizard.kt
@@ -92,7 +92,7 @@ class BolusWizard @Inject constructor(
 
     init {
         injector.androidInjector().inject(this)
-        // TODO: why [email protected] not visible in scoped DetailedBolusInfo().apply
+        // why [email protected] not visible in scoped DetailedBolusInfo().apply
         // phoneNumber = preferences.get(StringKey.SmsReceiverNumber)
         timeStamp = dateUtil.now()
     }

diff --git a/plugins/main/src/main/kotlin/app/aaps/plugins/main/general/overview/OverviewPlugin.kt b/plugins/main/src/main/kotlin/app/aaps/plugins/main/general/overview/OverviewPlugin.kt
@@ -47,7 +47,6 @@ import app.aaps.core.validators.preferences.AdaptiveClickPreference
 import app.aaps.core.validators.preferences.AdaptiveDoublePreference
 import app.aaps.core.validators.preferences.AdaptiveIntPreference
 import app.aaps.core.validators.preferences.AdaptiveIntentPreference
-import app.aaps.core.validators.preferences.AdaptiveStringPreference
 import app.aaps.core.validators.preferences.AdaptiveSwitchPreference
 import app.aaps.core.validators.preferences.AdaptiveUnitPreference
 import app.aaps.plugins.main.R

diff --git a/ui/src/main/kotlin/app/aaps/ui/dialogs/InsulinDialog.kt b/ui/src/main/kotlin/app/aaps/ui/dialogs/InsulinDialog.kt
@@ -131,9 +131,9 @@ class InsulinDialog : DialogFragmentWithDate() {
         val pump = activePlugin.activePump
         if (config.NSCLIENT) {
             // If SmsAllowRemoteCommands is True, then user might use either SMS command or record only, otherwise hardcode record_only option
-            val allow_sms = preferences.get(BooleanKey.SmsAllowRemoteCommands)
-            binding.recordOnly.isEnabled = allow_sms
-            binding.recordOnly.isChecked = if (allow_sms) preferences.get(StringKey.SmsReceiverNumber).isNullOrBlank() else true
+            val allowSms = preferences.get(BooleanKey.SmsAllowRemoteCommands)
+            binding.recordOnly.isEnabled = allowSms
+            binding.recordOnly.isChecked = preferences.get(StringKey.SmsReceiverNumber).isNullOrBlank()
         }
         val maxInsulin = constraintChecker.getMaxBolusAllowed().value()