Overview add Sensitivity OKDialog #3580
Conversation
|
Thumbs up from me. |
plugins/main/src/main/kotlin/app/aaps/plugins/main/general/overview/OverviewFragment.kt
Outdated
Show resolved
Hide resolved
plugins/main/src/main/kotlin/app/aaps/plugins/main/general/overview/OverviewFragment.kt
Outdated
Show resolved
Hide resolved
|
I'm not sure about this |
|
I'm not at home this week-end, will check again everything on sunday afternoon 😉. |
|
Built with latest commit (without dedicated UiThread), and works fine on my side 😉 |
|
This is how overview screen looks now if DynISF and DynTDDSensitivty is enabled. I think it's time to move some information away from the overview screen and into this Sensitivity OKDialog, it will make the overview screen less stretched and we have the possibility to explain more what each number is for. My suggestion is to always show only one line, and move other information to the OkDialog: If Dynamic Sensitivity = EnabledIn Overview: OKDialog: If Dynamic Sensitivity = DisabledIn Overview: (Only show Autosens %) OKDialog: |
|
How it looks with mg/dl |
|
That's why I think average ISF should be moved to OKDialog...
We can also probably adjust ISF rounding value with one decimal for mmol unit and no decimal for mgdl and reduce overall width. |
|
Agreed, "ISF for carbs absorption" isn't a precise name though as it is also used in Bolus calculator BG/Trend calculation. @MilosKozak @Philoul @vanelsberg @jbr7rr @ga-zelle For me the DynISF used for SMB algo is most useful to see in Overview without having to click on sensitivity icon. ISF for bolus calc is also visible when opening bolus calc. Gathering all relevant sensitivity numbers in this box provides a better user experience imo, as we can explain them all abit more. |
|
I like "only one line" with main information visible (AutoSens with OpenAPS SMB, no need to provide OKDialog), Profile and variable ISF Values for DynISF and AutoISF (then Additional info like Avg ISF, Autosens value, ISF detailed info...), could be different with DynISF and AutoISF... "ISF for Carbs absorption" was a proposal (string short enough to have label and value in one ĺine). |
|
Yes, one line only. Its content depends on the current plugin or mode. My vote is mostly percentage of final ISF compared to profile value with the exeption of active DynISF where it is shown as absolute value without showing the profile value in overview. |
Have been on OpenSMB (which is also showing this) and found it quite informative as it shows my deviations on ISF from profile and actual ISF calculated? So for me, I'm quite happy with the view as is currently... 🤔 |
|
I find that this corner is overcrowded. Even the last ) can't be seen and it pushes all the other numbers (COB IOB) to the left. Either we can show one number and tap to have a window with more info (as in IOB) or we have to move around the numbers or/and make them smaller.
Move the AS next to the icon and delete the average in (). It can be seen with a tap in a new window as it is not very useful to have it all the time. The above screenshots were with AutoISF. Also, if I'm on OpenSMB with DynISF turned OFF, I don't need to see what my ISF would be if I had DynISF tuned ON... I'd like to get that info after a tap to get detailed info. |
|
And, the actual situation is not great with the widget either...
|
For me it is showing just fine. Try resizing the widget? |
For me, it has value in a sense that I can see what algo is doing and what impact sensitivity has (or would have)? A -> B (C) (Note that currently Calculator is using C) |
Nope, just deleted the widget and set it up again with the sale result |
What I need to see all the time is
A tap on those numbers can give me all the details one can wish for. Another positif side is that DynISF and AutoISF can have the same screen output. On the main UI, above the ISF numbers, we can have the AutoSens % and a small icon to show if it is ON or OFF. The on/off information can be given by text color too. |
It's the proof it cannot remain "As is" You are a skilled user, knows perfectly well AAPS, but your explains are wrong... |
Ah yes, I see now :-|
|
Agree, this could be a valid alternative. |
That is strange. |
|
I had a similar squeeze problem where a whole line was missing. Solved by reducing the general font size of the phone. |
|
Yes, if I make the font smaller (2nd position), it fits. But, I'm only using the third position out of 8 possible and I'm 62 y.o. 😉 |
|
An idea this morning for single line short info in Overview: Icon above AS value has a double Arrow (with or without X) according to AS disabled or enabled.
OpenAPS AMA or SMB: In OKDialog (TBC if we need it or not)
DynISF or AutoISF:
In OKDialog:
Widget is a side effect of the too long string and should be fixed if we reduce the size 😉 |
|
Regarding the Alg: %% (or middle row if present) I think this comes from TT changing sensitivity |
|
PR updated:
AS always visible with openAPS SMB With DynISF or AutoISF
Example with AS 111% (with autosens range 70%-130%, AS is only hidden between 94%-106% so visible here)
|
| @@ -430,6 +430,11 @@ | |||
| <string name="formatPercent">%1$.0f%%</string> | |||
| <string name="basal">Basal</string> | |||
| <string name="basalpct">Basal %</string> | |||
| <string name="sensitivity">Sensitivity</string> | |||
| <string name="isf_for_carbs">ISF for carbs absorption: %1$.1f</string> | |||
There was a problem hiding this comment.
How could we improve this string without making it to long? This ISF value is also used in Bolus calculator BG / Trend. This is very relevant information that we should present some how.
ISF for bolus and COB calculation
ISF for bolus calculator and COB calculation
ISF for bolus calculator and carbs absorption
ISF for bolus calc and carbs absorption
There was a problem hiding this comment.
Difficulty is none of your proposal fit in one line only for label + value (and they are in english language)
We should also think of translation (even if not directly under control), that can be longer...
All these label re in string so can be adjusted later if everyone agree on a better proposal ;-)
There was a problem hiding this comment.
I would go for this alternative text to cover that this ISF value is used in bolus calc:
"ISF for bolus calc and carbs absorption" or "ISF for bolus and COB calculation"
It's not much longer then
"ISF for carbs absorption"
There was a problem hiding this comment.
It's enough yo have string in 2 lines instead of 1, at least on my phone... (1080x2340 pixel), so I can't imagine on a low res screen...
Did you try on your side?
There was a problem hiding this comment.
I haven't tried. But for my part there is not a big deal if string goes into two lines as there is plenty of space.
OpenAPS log can cover half the screen some times.
|
Thumps up from me. I think we all should have some win in it regardless of opinions :) and a good start that can be built upon. My only suggestion is try to improve the string about ISF for bolus calc/cob calc, see comment above. P.S. some merge conflicts, so hard to test it |
…tivity # Conflicts: # plugins/main/src/main/kotlin/app/aaps/plugins/main/general/overview/OverviewFragment.kt
I saw that, it's fixed... |
|
Widget updated (within widget I kept everything always visible, so AS: xxx%, Alg: xxx% and variable sens are visible whatever the precentage value) Feel free to test and give me comments... |
|
As a method of rapid prototyping I once created a spreadsheet to show what the OKDialog box could look like under various conditions. That avoids the whole cycle of editing, building, testing and waiting for the relevant condition to occur. Here is a version with a bit more detail on AutoISF which is still under discussion between @Philoul and me. The DynISF case is bare bones because I don't know enough about the various conditions and combinations. |
|
Another thing to think about is AAPSClient. Edit: not entirely sure how this work without PR so will test abit more. |
|
This first PR will be limited to AS, Algo and avg ISF only. |
|
@olorinmaia your screenshot with inconsistancies between AAPS AS value and AAPSClient AS value is not linked to this PR, so should be managed outside... What is important here fot this PR is the consistancy in AAPSClient between what we had before (2 or 3 lines) and what we have now (one line most of the time + OKDialog) 😉 |
|
I realized I can't test this right now because I am missing TDD on my test rig. Are you able to or someone else? Dynamic sensitivity is enabled and functioning: |
|
Functionality tested OK with AAPSCLient. AS%, DynISF and DYnISF for carb absorption sync ok. Also the new arrows.
|
|
I tested this PR and AS is only in dialog. |
|
With latest version AS is hidden when 100% (most of the time), but you have the double arrow above. Then when AS is less than 20% to autosens min or max you only have the simple arrow above (up or down) and value is also hidden...
I put a 20% limit (arrow above gives a visual information if AS is a bit above or below 100%), but if you prefer I can reduce limit or always show AS if not equal to 100%. With dynamic icon above, I think we can hide AS when equals 100% (should be most of the time)... |
|
ok |
|
https://www.facebook.com/share/p/15boWpDu2s/ One of many post recent days about all the information shown under the sensitivity icon. What if we only show AS: X% in overview screen. And if using dynamic sensitivity we also show Alg: x% if enabled. But, imo we should use the okdialog to explain all these numbers properly also. The text should be so long that users understand. Autosens: X% (Should we inform when in dynisf mode that it has no effect?) |
|
In a first implementation it suffices to show 3 or 4 numbers appearing now in overview and reduce that to just one piece of info like final isf %. We cannot explain "everything" in that dialog box anyway. |
|
This is not about explaining everything, but in my opinion the minimum required, and it is not much text. TDD isn't high priority, but it would be nice there to have eventually. These numbers are pretty important, and it shouldn't be needed to ask on facebook/discord or search in wiki to understand what's going on. Luckily I can translate it as I wish in Norwegian, but base-line and most used is English, so we should try to explain these numbers as good as possible in the OKDialog box. |
|
I'm not sure if showing sensitivity (autosens) percentage when the function is turned OFF is really necessary. I turned it off as it really doesn't fit me (shows high percentage when I'm already lowish and definitely got more insulin than needed). So, seeing a wrong % showing is really not helpful. |
|
@robertrub Now that you used AutoISF for a while which single info would you like to see on the overview screen? |
|
This is the only information I need to see all the time: Profile ISF changed to AutoISF value. Instead of the 2 arrows for AutoSens, we can have an AutoISF icon too but that really is only aesthetic. |
|
Hum, no added value to have an AutoISF (DynISF) Icon here... I think the dynamic Arrow (not always "Double" but "Up" or "Down" according to Autosens value is more usefull). Using AutoISF, it's the same for me, most important info are the 2 ISF values (profile -> AutoISF). Current PR version includes an "automatic threshold" hardcoded to 20% of Min/Max Autosens values, to show or not AS value (below this threshold you only have the up or down arrow, or double arrows if equals 100%).
Note that for widget, I kept almost everything (AS and ISF always visible). |
| <string name="isf_for_carbs">ISF for carbs absorption: %1$.1f</string> | ||
| <string name="autosens_long">Autosens Value: %.0f%%</string> | ||
| <string name="autosens_short">AS: %.0f%%</string> | ||
| <string name="algorithm_long">Autosens in Loop: %.0f%%</string> |
There was a problem hiding this comment.
Suggestion to improve it:
Autosens used in algorithm
To align with short name "Alg"
…tivity # Conflicts: # plugins/main/src/main/kotlin/app/aaps/plugins/main/general/overview/OverviewFragment.kt
|
|
Within latest update, String has been modified (see below before and after to compare) and AS is now always visible if not equal to 100%. |
Include for Autosens area the same kind of OKDialog that we have for Basal or IOB
Il allow a shorter string with DynISF and AutoISF below autosens (ISF for Carbs is hidden), And OKDialog improve the understanding with an explicit string.
I also included the possibility to include more information on Variable ISF calculation (don't know for DynISF if it could be usefull to see for ex the different TDD included for ISF calculation or BG contribution, but for AutoISF I think we will be able to include usefull information)
Currently String from APS plugin are not included (I will try to propose a "User Friendly String" for AutoISF, and if possible not a "Dev Friendly String" 😉 )