Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI : Better color for light mode #3612

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

TheNeskik
Copy link
Contributor

This PR is about changing some color when using light mode.
Some color choice make some button or information hardly readable (bottom button for example).
That's why I'm proposing some color changes that improve readability.

Old color :
Screenshot_20241212_193046

New :
Screenshot_20241212_193526

@MilosKozak
Copy link
Contributor

others: thoughts?

@Philoul
Copy link
Contributor

Philoul commented Dec 13, 2024

First to be cristal clear, I'm not using myself the light theme...

I think it's better to not have exactly the same background color for the buttons compare to graph background (Profile/target on the top and 4 buttons on the bottom...).
Maybe grey is a bit too dark currently, with not enough constrast with icon colors, but I think proposal is "too light" and we should still have visible differentiation. I think we should also have graph menu buttons background color also harmonized (it's another reason to not have the same background color compare to graphs)

Other comment, black font for profile and Target is much better...

@TheNeskik TheNeskik marked this pull request as draft December 13, 2024 10:58
@TheNeskik
Copy link
Contributor Author

You are right ! Buttons must be on different color to make it easier to find.

I also find Temp Basal hard to read but I didn't want to change it as it will differ from dark mode.

Screenshot_20241213_115818

@kenzo44
Copy link
Contributor

kenzo44 commented Dec 24, 2024

@TheNeskik looks good! Can you remove the pink background and just have solid white.

For the temp basal, we can change the color to a blue that works well with both light and dark

@Philoul
Copy link
Contributor

Philoul commented Dec 24, 2024

For the temp basal, we can change the color to a blue that works well with both light and dark

I wouldn't change any color used on dark mode, everything has been harmonized (including watchface colors and tiles button).
The same colors look different if associated with a dark or a light background, so I think we could cheat a bit with the blue color to make it "look the same" on light mode (and improve constrast with background) even if a bit different compare to the blue used dark mode 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants