Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component testing setup #77

Merged
merged 11 commits into from
Dec 9, 2022
Merged

Component testing setup #77

merged 11 commits into from
Dec 9, 2022

Conversation

harshit-bs
Copy link
Member

@harshit-bs harshit-bs commented Nov 21, 2022 •
edited
Loading

@harshit-bs harshit-bs changed the title Component testing initial setup Component testint setup Nov 22, 2022
@harshit-bs harshit-bs changed the title Component testint setup Component testing\ setup Nov 22, 2022
@harshit-bs harshit-bs changed the title Component testing\ setup Component testing setup Nov 22, 2022
@vishalshah133
Copy link

Hey, @beatfactor Can we update the 1st question to single select with the following options?
End to End
Component
Both

Lesser things to read and lesser actions

@beatfactor
Copy link
Member

Hey, @beatfactor Can we update the 1st question to single select with the following options? End to End Component Both

Lesser things to read and lesser actions

I'm not sure. The next question will be a multi-select (browsers) so that's why I thought that we could keep the same design. We will also have API testing soon, so then we would have to change the design if we go for the single select.

@harshit-bs harshit-bs marked this pull request as ready for review December 1, 2022 09:59
beatfactor
beatfactor reviewed Dec 1, 2022
View reviewed changes
src/constants.ts Outdated Show resolved Hide resolved
beatfactor
beatfactor reviewed Dec 1, 2022
View reviewed changes
src/constants.ts Outdated Show resolved Hide resolved
harshit-bs and others added 2 commits December 1, 2022 19:52
@harshit-bs @beatfactor
Update src/constants.ts
b7da3ac 
Co-authored-by: Andrei Rusu <[email protected]>
@harshit-bs @beatfactor
Update src/constants.ts
6b653f9 
Co-authored-by: Andrei Rusu <[email protected]>
beatfactor
beatfactor reviewed Dec 2, 2022
View reviewed changes
src/init.ts Outdated Show resolved Hide resolved
beatfactor
beatfactor requested changes Dec 2, 2022
View reviewed changes
Copy link
Member

@beatfactor beatfactor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a few more tests here.

@beatfactor beatfactor merged commit 0a4e11e into main Dec 9, 2022
@beatfactor beatfactor deleted the feat/ct-setup branch December 9, 2022 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatfactor beatfactor beatfactor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshit-bs @vishalshah133 @beatfactor