Re-Implement -vrmode from OpenVR for use within OpenXR #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you mind updating your PR with the changes we discussed and the documentation accordingly? New arguments should be documented. Also you must sign your commits otherwise I can't merge. |
Meivyn
reviewed
Feb 6, 2025
| @@ -126,23 +126,16 @@ public static void SetOpenXRRuntime(string[] arguments) | |||
|
|
|||
| targetRuntime = targetRuntime.ToLower(System.Globalization.CultureInfo.CurrentCulture); | |||
There was a problem hiding this comment.
Please use ordinal comparison whenever possible instead of ToLower, as you did below. Also, I'd rather enforce it being case-sensitive than not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will do nothing if using an OpenVR build (pre-1.29.4) as its using a feature of OpenXR
https://registry.khronos.org/OpenXR/specs/1.0/loader.html#_table_of_debug_environment_variables