prov/tcp: Pass through rdm_ep flags to msg eps.

This patch sets the msg_ep cq completion flags based on those inherited from the rdm endpoint. This ensures that flags set by the application while creating an rdm endpoint are preserved by the msg_ep. Signed-off-by: Nikhil Nanal <[email protected]>
nikhilnanal · Oct 20, 2023 · 96a2f37 · 96a2f37
1 parent dc10729
commit 96a2f37
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/prov/tcp/src/xnet.h b/prov/tcp/src/xnet.h
@@ -584,9 +584,9 @@ xnet_set_commit_flags(struct xnet_xfer_entry *xfer, uint64_t flags)
 static inline uint64_t
 xnet_tx_completion_get_msgflags(struct xnet_ep *ep, uint64_t flags)
 {
-	/* Generate a completion if msg flags indicate or we generate
-	 * completions by default
-	 */
+	/* Generate a completion if msg flags indicate or app
+	*  requests
+	*/
 	return (ep->util_ep.tx_msg_flags | flags) & FI_COMPLETION;
 }
 

diff --git a/prov/tcp/src/xnet_progress.c b/prov/tcp/src/xnet_progress.c
@@ -717,7 +717,6 @@ static int xnet_handle_ack(struct xnet_ep *ep)
 	assert(!slist_empty(&ep->need_ack_queue));
 	tx_entry = container_of(slist_remove_head(&ep->need_ack_queue),
 				struct xnet_xfer_entry, entry);
-	printf("%d:handle_ack:%p", getpid(), tx_entry);
 	xnet_report_success(tx_entry);
 	xnet_free_xfer(xnet_ep2_progress(ep), tx_entry);
 	xnet_reset_rx(ep);
@@ -1101,7 +1100,6 @@ static void xnet_complete_rx(struct xnet_ep *ep, ssize_t ret)
 	}
 
 	if (!(rx_entry->ctrl_flags & XNET_SAVED_XFER)) {
-		printf("%d:IN complete_rx: rx_entry:%p, context:%p\n",getpid(), rx_entry, rx_entry->context);
 		xnet_report_success(rx_entry);
 		xnet_free_xfer(xnet_ep2_progress(ep), rx_entry);
 	} else {

diff --git a/prov/tcp/src/xnet_rdm_cm.c b/prov/tcp/src/xnet_rdm_cm.c
@@ -161,6 +161,11 @@ static int xnet_bind_conn(struct xnet_rdm *rdm, struct xnet_ep *ep)
 		if (ret)
 			return ret;
 	}
+	ep->util_ep.tx_msg_flags = rdm->util_ep.tx_msg_flags;
+	ep->util_ep.rx_msg_flags = rdm->util_ep.rx_msg_flags;
+	ep->util_ep.tx_op_flags = rdm->util_ep.tx_op_flags;
+	ep->util_ep.rx_op_flags = rdm->util_ep.rx_op_flags;
+
 
 	return 0;
 }