Ensure defaults for float/double generation result in random values

Also ensures generating BigIntegers with a default range can contain some nulls.
niloc132 · Oct 27, 2023 · c62aa2e · c62aa2e
1 parent 0b289ba
commit c62aa2e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.../test-utils/src/main/java/io/deephaven/engine/testutil/generator/BigIntegerGenerator.java b/.../test-utils/src/main/java/io/deephaven/engine/testutil/generator/BigIntegerGenerator.java
@@ -20,7 +20,7 @@ public BigIntegerGenerator() {
 
     public BigIntegerGenerator(double nullFraction) {
         this(BigInteger.valueOf(Long.MIN_VALUE).multiply(BigInteger.valueOf(2)),
-                BigInteger.valueOf(Long.MAX_VALUE).multiply(BigInteger.valueOf(2)), 0);
+                BigInteger.valueOf(Long.MAX_VALUE).multiply(BigInteger.valueOf(2)), nullFraction);
     }
 
     public BigIntegerGenerator(BigInteger from, BigInteger to) {

diff --git a/engine/test-utils/src/main/java/io/deephaven/engine/testutil/generator/DoubleGenerator.java b/engine/test-utils/src/main/java/io/deephaven/engine/testutil/generator/DoubleGenerator.java
@@ -74,7 +74,7 @@ private double generateDouble(Random random) {
                 return Double.POSITIVE_INFINITY;
             }
         }
-        return from + (random.nextDouble() * to - from);
+        return (from / 2 + (random.nextDouble() * (to / 2 - from / 2))) * 2;
     }
 
     @Override

diff --git a/engine/test-utils/src/main/java/io/deephaven/engine/testutil/generator/FloatGenerator.java b/engine/test-utils/src/main/java/io/deephaven/engine/testutil/generator/FloatGenerator.java
@@ -69,7 +69,7 @@ private float generateFloat(Random random) {
                 return Float.POSITIVE_INFINITY;
             }
         }
-        return from + (random.nextFloat() * to - from);
+        return (from / 2 + (random.nextFloat() * (to / 2 - from / 2))) * 2;
     }
 
     @Override