V2 🥳 #6
Merged
V2 🥳 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the legacy API (vue-i18n's current default), and not the composition api. However, the legacy API was disabled in the build configuration in vite.config.ts which is now fixed.
The changes done in f5939ac8j in provider-assets.ts don't achieve the desired effect of the actual translation happening in ProviderBanner, because in production builds, translation keys are replaced with simple numbers, while the strings that were returned remained as is, and are therefore not valid translation keys anymore when passed to i18n-t in ProviderBanner. Now, the translation already happens in prover-assets.ts and is then passed to ProviderBanner's i18n-t, where the translation will be an unknown translation key, which will simply be preserved.
As otherwise the provider tooltip is cut off on Desktop
Default to IP if user denied geolocation services Added circle spinner while loading data
The text interpolation of provider banners is now solved more elegantly by defining the translation keys in provider-assets.ts, but the actual translation happening in ProviderBanner by passing the translation keys to ProviderBanner.
Changed recycle scroll to dynamic to auto adjust to element height
In the mobile sheet when clicking on the gmaps icon it opened the card, now it clicks on the button
✅ Deploy Preview for nimiq-map ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.