Support sending new native USDC #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move commented ABI to new file that is not part of the deployment.
mraveux
reviewed
Dec 19, 2023
mraveux
approved these changes
Dec 19, 2023
danimoh
approved these changes
Jan 5, 2024
|
|
||
| NATIVE_USDC_TRANSFER_CONTRACT_ABI: [ | ||
| 'function transfer(address token, uint256 amount, address target, uint256 fee)', | ||
| 'function transferWithPermit(address token, uint256 amount, address target, uint256 fee, uint256 value, bytes32 sigR, bytes32 sigS, uint8 sigV)', |
There was a problem hiding this comment.
Is value the permit?
Can this name be changed?
There was a problem hiding this comment.
It is the permit amount yes. Unfortunately, it cannot be changed, as the hash of the function signature is used for it's identification, meaning changing any argument name changes the ID.
| const domain = { | ||
| name: 'USD Coin', // This is currently the same for testnet and mainnet | ||
| version: '2', // This is currently the same for testnet and mainnet | ||
| verifyingContract: CONFIG.NATIVE_USDC_CONTRACT_ADDRESS, |
There was a problem hiding this comment.
I wonder whether the old contract should actually also become LEGACY_USDC_CONTRACT_ADDRESS or BRIDGED_USDC_CONTRACT_ADDRESS, now that native usdc is meant to become the main usdc.
There was a problem hiding this comment.
Can be done, yes. I will do it in a follow up PR to not litter this one 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the necessary config, handlers, validators and implementations to allow signing new native USDC transactions, which use a slightly different contract ABI, but which works the same. Approval is now called Permit, and the permit is signed with different data.
The Hub changes that go with this are minimal: nimiq/hub@3504e77