Correctly count length of password with multibyte characters #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, any non-ASCII characters were simply ignored for password strength.
sisou
force-pushed
the
soeren/password-length
branch
from
60732fd to
f6c9a22
Compare
onmax
approved these changes
Jan 8, 2024
src/lib/PasswordStrength.js
Outdated
| count.upperCase += 1; | ||
| } else if (characters[i].match(/[0-9]/g)) { | ||
| count.numbers += 1; | ||
| } else if (characters[i].match(/[^a-z]/)) { |
There was a problem hiding this comment.
Subjective take: Easier to read
!characters[i].match(/[a-z]/), instead of
characters[i].match(/[^a-z]/)
Probably not worth changing
There was a problem hiding this comment.
Thanks, this is a great suggestion! Code readability is a priority in the security-relevant Keyguard.
Eligioo
approved these changes
Jan 9, 2024
|
LGTM |
|
I would include some comments on why using the spread operator makes a difference in the lenght. Otherwise, LGTM 👍🏼 |
Albermonte
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the way password character length is counted to use the recommended method from MDN for strings with potential multibyte characters.
Additionally, this method is applied to the password strength calculator to always handle full characters, not "lone surrogates".