Fiat api refactor #503
Merged
Fiat api refactor #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…list Switch back to the public CoinGecko API as we shut down our custom API endpoint. The public API is accessible from the keyguard domain with no issues and the usage limits are sufficient for the Keyguard's needs. Also update the list of currencies supported by CoinGecko.
sisou
reviewed
Jul 24, 2024
mraveux
approved these changes
Aug 12, 2024
danimoh
force-pushed
the
daniel/fiat-api-refactor
branch
from
dcbd088 to
583af46
Compare
sisou
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FiatApiin@nimiq/utils, with dynamic providers, currency support depending on the chosen provider, type generics for the chosen provider etc. However, in the Keyguard, it can be quite a bit easier, as the provider can be considered a fixed value. Based on that value (which currently is only CoinGecko), I'm simply setting, for example, the appropriate list of supported currencies and the api endpoint, also as fixed values. Typescript seems to be happy with this. Maybe a more modern typescript version might complain, or if a second provider is actually added, but in that case all code and types for the inactive provider can simply be commented out to circumvent such issues.