-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CRC Adapter #1
base: main
Are you sure you want to change the base?
Conversation
327e08c
to
7c44fe9
Compare
@sisou quick question. The last arg in
The error was not being triggered before, but now with the new class definition I get it:
|
Hmm. It technically is correct though, because |
For now, can you try changing the implementation from |
I found another solution where Typescript does not complaint and it is the minimum amount of changed lines. |
a8b3bde
to
8eb50e7
Compare
cd6428e
to
6f4fb69
Compare
package.json
Outdated
@@ -27,7 +27,7 @@ | |||
"dependencies": { | |||
"@nimiq/core-web": "^1.5.8", | |||
"@nimiq/electrum-client": "https://github.com/nimiq/electrum-client#build", | |||
"@nimiq/oasis-api": "^1.0.1", | |||
"@nimiq/oasis-api": "github:nimiq/oasis-api-js#dbfcdf4707c8a030022b3474126f4596bacbc1c1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
: Update to released package version once nimiq/oasis-api-js#1 is merged
The adapter is just a exact copy from
EURAssetAdapter.ts