Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add icon info for validator #17

Merged
merged 4 commits into from
Nov 16, 2024
Merged

add icon info for validator #17

merged 4 commits into from
Nov 16, 2024

Conversation

gallareton
Copy link
Contributor

No description provided.

@onmax
Copy link
Member

onmax commented Nov 16, 2024

Hey, thanks for your PR

You need to prepend data:image/svg+xml;base64 in the icon:

data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSI0OTkiIGhlaWdodD0iNDQwIj48cGF0aCBmaWxsPSIjRkZDMTA3IiBmaWxsLXJ1bGU9ImV2ZW5vZGQiIGQ9Ik0zODkgMjFjLTYtMTItMjMtMjEtMzYtMjFIMTQ1Yy0xMyAwLTI5IDktMzYgMjFMNSAxOTljLTYgMTEtNiAzMCAwIDQxbDEwNCAxNzhjNyAxMiAyMyAyMSAzNiAyMWgyMDhjMTQgMCAzMC05IDM2LTIxbDEwNC0xNzhjNy0xMSA3LTMwIDAtNDFMMzg5IDIxek0yNzMgMzQ3djQyaC0zOXYtNDBjLTI0LTMtNTItMTMtNzAtMzBsMjUtMzljMjEgMTUgMzggMjMgNTcgMjMgMjMgMCAzMy05IDMzLTI4IDAtNDAtMTA2LTM5LTEwNi0xMTEgMC0zOCAyMy02NSA2MS03M1Y1MWgzOXY0MGMyNSAzIDQ0IDE2IDU5IDMybC0yOSAzM2MtMTUtMTMtMjctMjAtNDQtMjAtMTkgMC0yOSA4LTI5IDI2IDAgMzcgMTA1IDM0IDEwNSAxMTAgMCAzNy0yMSA2Ny02MiA3NXoiLz48L3N2Zz4=

I recommend using #FFC107 as the accentColor. #ffffff might blend in too much and could be less effective in most designs.

Let me know what you think! :)

@gallareton
Copy link
Contributor Author

gallareton commented Nov 16, 2024

Hey, thanks for your PR

You need to prepend data:image/svg+xml;base64 in the icon:

Sure, will do, thank you for correction :)

I recommend using #FFC107 as the accentColor. #ffffff might blend in too much and could be less effective in most designs.

Let me know what you think! :)

What's the purpose of the accentColor? It's documented as "required when icon is set" but it's function isn't described

@onmax
Copy link
Member

onmax commented Nov 16, 2024

We don't use it much at the moment, but where we do use it is in a graphic I'm working on.

image

In the future, this accentColor might be used in other designs from us, but also from the community who want to build something cool :)

@onmax
Copy link
Member

onmax commented Nov 16, 2024

Thanks!

@onmax onmax merged commit 6b6ec8c into nimiq:main Nov 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants