Add new deploy script #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisou
reviewed
Nov 25, 2024
and remove the default deployer value as well as put the message under the -m parameter for consistency
|
I applied the feedback from @sisou, lemme know if that's better for you ;) |
|
The script has been tested for release v3.0.11 and seems to work. Except that, the script is considered done, until further feedbacks. |
|
Just pushed some error handling. |
danimoh
approved these changes
Nov 26, 2024
For example “—same-as=testnet —mainnet” will deploy the version already deployed on the testnet to the mainnet
mraveux
force-pushed
the
matheo/release-script-update
branch
from
8985c52 to
493bb28
Compare
danimoh
reviewed
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replace the previous release.sh script by a new ./src/deploy.sh script taking care of the release steps for you.
The script is currently untested, thus the PR and not the instant push on master.
Once the script is tested and accepted, the PR will be merged.
Edit:
The script has been tested, and used to deploy the last wallet versions on testnet & mainnet, and seems to work as expected and handle most obvious edge cases.