always load the openssl extension #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrox
reviewed
Dec 1, 2023
| @@ -448,7 +449,7 @@ func writeComposerPhpIni(logger scribe.Emitter, context packit.BuildContext) (co | |||
|
|
|||
| phpIni := fmt.Sprintf(`[PHP] | |||
| extension_dir = "%s" | |||
| extension = openssl.so`, os.Getenv(PhpExtensionDir)) | |||
| extension = %s.so`, os.Getenv(PhpExtensionDir), opensslExtension) | |||
There was a problem hiding this comment.
You know why openssl is in here in the first place?
There was a problem hiding this comment.
Don't know exactly. composer install installs modules from somewhere. So a HTTPS connection might be needed. The composer installer also seems to check for the extension.
ctrox
approved these changes
Dec 1, 2023
This should fix potentially missing openssl extensions (reported in paketo-buildpacks/composer#27). The fix is to always load openssl.so.
thirdeyenick
force-pushed
the
always-enable-openssl
branch
from
8dea3ac to
3fc9482
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix potentially missing openssl extensions (reported in paketo-buildpacks/composer#27). The fix is to always load openssl.so.