feat: add env var to configure webroot #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a new env var that overrides the webroot and will also allow it to pass detection even if there is no `public.html` in any of the expected places.
pawelkuc
approved these changes
Dec 15, 2023
| @@ -40,6 +43,11 @@ func Detect(logger scribe.Emitter) packit.DetectFunc { | |||
| } | |||
|
|
|||
| func WebRoot(workingDir string) (string, error) { | |||
There was a problem hiding this comment.
I know this isn't part of this PR but I see that we never use the return string value. Maybe there is a plan to consume it somewhere in the future?
There was a problem hiding this comment.
we use it in the other buildpack :)
pawelkuc
approved these changes
Dec 15, 2023
pawelkuc
approved these changes
Dec 15, 2023
ctrox
added a commit
to ninech/buildpack-static-confgen
that referenced
this pull request
Dec 15, 2023
See ninech/buildpack-static-require#4 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a new env var that overrides the webroot and will also allow it to pass detection even if there is no
public.htmlin any of the expected places.