-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use out_prefix instead of "w" in spm.Normalize12 #3600
Conversation
Currently, for the Normalize12 process in spm, the user can define the out_prefix parameter, but this is not used to generate output, as it is hard-coded to 'w' in Normalize12._list_outputs().
This seems reasonable, but does it work? I don't see where the updated file names would be passed to SPM to tell it to write to those files. |
Yes it is working.
I confess I didn't look into the nipype machinery to see exactly where the updated filenames would be passed to SPM to tell it to write to those files. ... However, concretely, with the small modification I propose, it works directly with nipype or in our environment (populse). |
Sounds good. Could you go ahead and run |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3600 +/- ##
=======================================
Coverage 63.18% 63.18%
=======================================
Files 308 308
Lines 40809 40809
Branches 5652 5652
=======================================
Hits 25784 25784
Misses 14013 14013
Partials 1012 1012
☔ View full report in Codecov by Sentry. |
Done! |
Thanks! |
Please consider this PR that will be fast to review:
I think there are two solutions.
1- Remove the
out_prefix
parameter and the prefix remains always at "w"or
2- use the
out_prefix
parameter instead of the hard-coded "w" value.I think the second solution is the right one.
I propose a slight modification to this effect.