Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Deduplicate dcm2niix output #3610

Merged

Conversation

mauriliogenovese
Copy link
Contributor

@mauriliogenovese mauriliogenovese commented Oct 9, 2023

fixes #3579

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.18%. Comparing base (682abac) to head (39b3a2c).
Report is 70 commits behind head on master.

❗ Current head 39b3a2c differs from pull request most recent head 45e8076. Consider uploading reports for the commit 45e8076 to get more accurate results

Files Patch % Lines
nipype/interfaces/dcm2nii.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3610      +/-   ##
==========================================
- Coverage   63.18%   63.18%   -0.01%     
==========================================
  Files         308      308              
  Lines       40809    40810       +1     
  Branches     5652     5652              
==========================================
  Hits        25784    25784              
- Misses      14013    14014       +1     
  Partials     1012     1012              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies
Copy link
Member

Apologies for the delay. Is it possible to write a test that reproduces the issue?

@mauriliogenovese
Copy link
Contributor Author

I cannot write a test without providing images from a subject and I don't have a public dataset. Anyway the pull request simply removes any duplicate entry from the final file list, so it would be fine in this and any other similar case.

@effigies effigies changed the title [FIX]Deduplicate dcm2niix output [FIX] Deduplicate dcm2niix output Mar 21, 2024
preserve ordering in output file list

Co-authored-by: Chris Markiewicz <[email protected]>
@effigies effigies merged commit 685a1fb into nipy:master Mar 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dcm2niix converted_files duplicate entry
2 participants