Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add GenericLabel to ANTS ApplyTransforms. #3617

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Dec 5, 2023

Summary

Fixes none, but is related to #3423 and #3424.

List of changes proposed in this PR (pull-request)

  • Add "GenericLabel" to list of valid interpolation types in ANTS's ApplyTransforms interface.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b066807) 63.15% compared to head (0114009) 63.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3617   +/-   ##
=======================================
  Coverage   63.15%   63.15%           
=======================================
  Files         308      308           
  Lines       40825    40825           
  Branches     5656     5656           
=======================================
  Hits        25781    25781           
  Misses      14031    14031           
  Partials     1013     1013           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -349,6 +349,7 @@ class ApplyTransformsInputSpec(ANTSCommandInputSpec):
"MultiLabel",
"Gaussian",
"BSpline",
"GenericLabel",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add traits.Tuple(traits.Str()) to interpolation_parameters options, as well.

@effigies effigies merged commit 5ef9fe4 into nipy:master Dec 6, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants