Fix/storm fixed global #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was half a pixel (0.05 degrees) out, as the source data is not aligned with integer degrees at the upper-left corner of cells.
thomas-fred
reviewed
Apr 5, 2024
| @@ -195,7 +202,7 @@ rule wrap_storm_fixed: | |||
| temp("{OUTPUT_DIR}/input/STORM/fixed/{STORM_MODEL}/{STORM_BASIN}/STORM_FIXED_RETURN_PERIODS_{STORM_MODEL}_{STORM_BASIN}_{STORM_RP}_YR_RP.wrapped.tif") | |||
| shell: | |||
| """ | |||
| gdalwarp -te -180 -60 180 60 {input} {output} | |||
| gdalwarp -te -179.85 -60.15 180.15 59.95 -co COMPRESS=LZW -co PREDICTOR=2 -co TILED=YES {input} {output} | |||
There was a problem hiding this comment.
Any particular reason why the changes are 0.15, 0.15, 0.15 and -0.05? I'd naively expect them to be the same in magnitude
There was a problem hiding this comment.
Its a little arbitrary in both directions. In the east-west direction, this avoids pulling a column across the antimeridian from WP to EP. In the north-south direction, this should match the maximum extent of the source data, without clipping but avoiding extra no-data rows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key change is to wrap STORM files to an extent aligned with the source files' pixels. This was half a pixel (0.05 degrees) out, as the source data aligns with integer degrees at the centre, not the upper-left corner, of some cells.