-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(render_com): update instructions #2536
base: main
Are you sure you want to change the base?
Conversation
There is no need for the `render.com` preset. I updated the steps to the latest render.com UI and I also added Bun as an alternative runtime which render.com supports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR. Left some suggestions. I love to followup on this PR as improvement to current docs:
- Add bun instructions
- Add UI wizard alternative to config usage
|
||
1. [Create a new Web Service](https://dashboard.render.com/select-repo?type=web) and select the repository that contains your code. | ||
2. Ensure the 'Node' environment is selected. | ||
3. Update the start command to `node .output/server/index.mjs` | ||
4. Click 'Advanced' and add an environment variable with `NITRO_PRESET` set to `render_com`. You may also need to add a `NODE_VERSION` environment variable set to `18` for the build to succeed ([docs](https://render.com/docs/node-version)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are reasons we have explicit preset please keep it.
envVars: | ||
- key: NITRO_PRESET | ||
value: render_com | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep this as alternative to web UI setup wizard.
Co-authored-by: Pooya Parsa <[email protected]>
Co-authored-by: Pooya Parsa <[email protected]>
π Linked issue
#2535
β Type of change
π Description
There is no need for the
render.com
preset. I updated the steps to the latest render.com UI and I also added Bun as an alternative runtime which render.com supportsπ Checklist