fix: serialization warning when primitives have prototype changed #2902
+74
β7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
No issue, do I need to open it?
β Type of change
π Description
Unfortunately there are a few libs that inject utils into prototypes, with the current implementation of
checkSerializableRuntimeConfig
ifString
or any other primitive has an util injected into the prototype a warning is thrown.I don't see any direct consequence of just ignoring it during the check, if that prototype is indeed needed it will be there once
JSON.parse
is used.An example of this is
forEachEmbeddedItem
where the ContentStack team added an util intoString.prototype
.I don't think libs should be polluting prototypes needlessly when it could very well be an exported function, but nitro shouldn't also be concerned about it since there is no consequence at all (right?).
Reproduction
π Checklist