-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend generated tsconfig paths
from aliases
#2964
Open
gioboa
wants to merge
5
commits into
nitrojs:v2
Choose a base branch
from
gioboa:fix/2476
base: v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
β0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
reviewed
Jan 3, 2025
options.typescript.tsConfig.compilerOptions.paths
options.typescript.tsConfig.compilerOptions.paths
paths
from aliases
Do I need to do the same change to v3? |
It will be ported to v3 branch. i need to test it little bit to merge for next minor (after patch) |
8 tasks
Thank you, itβs working great! However, the order needed to be adjusted, and the structure had to be improved. You can check out the new PR now. |
Do I need to close this one? |
No, @pi0 will decide after examining it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Fixes: #2476
β Type of change
π Description
To manage aliases inside the configuration and create the correct tsconfig file I merged the
alias
object with the typescript one ( that already works )To prevent errors we need to check the complex typescript object π
I added typeof checks to prevent errors with wrong configs like eg.
alias: 0
orpaths: true
π Checklist