Nixhash #120
Draft
Nixhash #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Extend to support all the encodings and algos supported by Nix. 2. Type things to make invalid representation harder. 3. Hide struct fields so validation only has to be done on construction. 4. Rename to `nixhash` so it doesn't clash with the stdlib hash package (and to make the back-compat breakage more obvious).
Nix can parse the hash in different ways, and Cachix decided to use Base16 for one of the fields.
|
Rebasing. Looks like I was working on an old branch |
|
Pls undraft when ready, happy to take a look then! |
zimbatm
added a commit
to numtide/nar-serve
that referenced
this pull request
Jul 27, 2024
Fixes the issues with cachix
zimbatm
added a commit
to numtide/nar-serve
that referenced
this pull request
Jul 27, 2024
Fixes the issues with cachix
zimbatm
added a commit
to numtide/nar-serve
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the nixhash package to make it more user friendly. Make narinfos compatible with Cachix