Add sources to override sources fetcher

[juliens]

This PR is a proposition to be able to override the source fetcher.

This can collide with #42 but I think it's a simpler solution to the problem.

User needs to define by itself how to fetch the dependency, but with that it works with all repository etc.. (no guessing).

The usage is pretty simple:

pkgs.buildGoApplication {
  pname = "my-app";
  version = "0.1";
  pwd = ./.;
  src = ./.;
  modules = ./gomod2nix.toml;
  sources = {
    "my-dependency_v0.10.0"= builtins.fetchGit {
      url = "[email protected]:test/my-dependency.git";
      ref = "master";
      rev = "xxxxxxxxx";
    };
  };
}

I just wonder if it is a problem that we don't verify the origin sha of the dependency and that we move the responsability of the "sha" on the fetchGit

WDYT?

[frederictobiasc]

Hi, this works for my private repositories. Would also be interested in knowing what the maintainers think of this solution.

[anthr76]

It would be nice to have support to pass in packages of private go modules so they can be easily re-used between derivations.

[tonybutt]

Anyway we can have this merged?

[frederictobiasc]

Anyway we can have this merged?

@marcusramberg: You merged some PRs recently. Maybe there is a chance you could have a look at that as well, since @adisbladis seems out of office?

[tonybutt]

I went down a huge path to get this working for myself and I landed on this as the cleanest way, imo

test = pkgs.buildGoModule {
            name = "test";
            src = gitignore.lib.gitignoreSource ./.;
            doCheck = false;
            ldFlags = "-mod=mod";
            vendorHash = "sha256-ZKp4eeZRFWbogDadB8ZJfBXhSYyVYq1uPpz2WekvtPg=";
            CGO_ENABLED = 0;
            overrideModAttrs = (oldAttrs: {
              impureEnvVars = oldAttrs.impureEnvVars or [ ] ++ [
                "NIX_GITLAB_TOKEN"
              ];
              preBuild = /* bash */ ''
                export HOME=$(mktemp -d)
                cat > ~/.netrc <<EOF
                machine YOUR_PRIVATE_REPO
                  login oauth2
                  password $NIX_GITLAB_TOKEN
                EOF
                export GOPRIVATE=YOUR_PRIVATE_REPO/*
                export GONOSUMDB=YOUR_PRIVATE_REPO
              '';

              preferLocalBuild = true;
            });
          };

Maybe we can use this as a way to inspire something that will support private repos? I actually don't even mind having to update the vendorHash when depends change with this method.

[anthr76]

@juliens can you rebase this branch?

[anthr76]

Thanks @juliens! I am noticing an issue in build:

error: builder for '/nix/store/bp37lm1x2l79sfmm5gz92xrnmyhxdi3y-omit-1.28.0.drv' failed with exit code 1;
       last 11 log lines:
       > Running phase: unpackPhase
       > unpacking source archive /nix/store/a3d53dch6pg6d36m4rgrg2my3nin03jg-source
       > source root is source
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Running phase: buildPhase
       > Building subPackage .
       > internal/omit/omit.go:8:2: cannot find module providing package github.com/omit/omit/api/v1alpha1: import lookup disabled by -mod=vendor

I assume this is because the go.mod in github.com/omit/omitcontains a replace.

So inside the vendor directory github.com/omit/omit/api/v1alpha1 is actually github.com/omit/omit is there any suggestions on working around this?