Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lsp server support to kate #121

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Conversation

Asqiir
Copy link
Contributor

@Asqiir Asqiir commented Apr 10, 2024

This PR adds LSP ("language server protocol") settings to kate.

It contains 2 preconfigured LSP servers – nil for nix and marksman for markdown. Users can add custom settings as well.

This PR is marked as a draft since I want to see whether these preconfigured LSP servers (nil and marksman) might be accepted into the kate project. If yes, we do not need these here.

@Asqiir
Copy link
Contributor Author

Asqiir commented Apr 17, 2024

They indeed accepted it!
https://invent.kde.org/utilities/kate/-/merge_requests/1456

So it will probably be included in the next stable release of kate, 24.08 if I understand their release cycle correctly. Who knows when that one arrives in nixos-unstable, given that it is still on 23.08 despite 24.02 being already out for a while.

For this PR that means that I will undo most of the changes and keep just the extra settings.

@Asqiir Asqiir force-pushed the kate-lsp branch 2 times, most recently from 2b6aae8 to 16c87f8 Compare April 17, 2024 21:41
@Asqiir Asqiir marked this pull request as ready for review April 17, 2024 21:41
Copy link
Collaborator

@magnouvean magnouvean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool that you managed to get this into kate. The pr looks good to apart from the one small comment. Do you reckon this is ready to be merged right away after this is fixed?

@Asqiir
Copy link
Contributor Author

Asqiir commented Apr 19, 2024

Yes, I think it is ready now

@magnouvean magnouvean merged commit b2d47ea into nix-community:trunk Apr 19, 2024
1 check passed
@Asqiir Asqiir deleted the kate-lsp branch April 19, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants