Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add locale to DateFormat #44

Merged
merged 4 commits into from
Feb 24, 2025
Merged

Conversation

CaoGiaHieu-dev
Copy link
Contributor

@CaoGiaHieu-dev CaoGiaHieu-dev commented Feb 21, 2025

Pull Request Checklist

What does this PR do?

Add local to DateFormat to transalate

Checklist

Code Changes

  • I have added new features to the package (e.g., custom time thresholds, new languages, etc.)
  • I have fixed existing issues (e.g., incorrect formatting, performance bottlenecks)
  • I have improved the overall structure or optimized the codebase

Documentation

  • I have updated the README file or relevant documentation with the changes
  • I have added code usage examples or updated existing examples to reflect changes
  • I have updated the package version in the pubspec.yaml file

Testing

General Tests

  • The package correctly formats time differences into human-readable strings
  • The package supports dynamic updates (e.g., changing locales, thresholds)

Localization

  • The package supports all documented languages
  • Custom locales can be added and work as expected
  • Language fallback works correctly if a specific locale is missing

Custom Thresholds

  • Custom time thresholds are applied correctly
  • The package handles edge cases like just now, future dates, or extreme past dates

Error Handling

  • The package handles null or invalid inputs gracefully
  • Fallback behavior works for unexpected or incorrect configurations

Responsiveness

  • The package adapts to time-zone differences accurately
  • The formatting responds correctly to locale changes in the app

Performance

  • The package performs efficiently, even when processing frequent or large updates
  • Performance tests show no regressions

How did you verify your code works?

@nixrajput nixrajput self-requested a review February 21, 2025 10:59
Copy link
Owner

@nixrajput nixrajput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases are failing.
Please check and correct the code.

@CaoGiaHieu-dev
Copy link
Contributor Author

CaoGiaHieu-dev commented Feb 24, 2025

Test cases are failing. Please check and correct the code.

Hi . seem like current testcase not correct because in my pr i only add locale to inlt DateFormat . Can you check it

@nixrajput
Copy link
Owner

nixrajput commented Feb 24, 2025

Hi @CaoGiaHieu-dev,

Please update the test cases to align with your recent changes. Also, ensure that all applicable checkboxes in the PR list are checked. All test cases must pass before I can merge this PR.

Thanks & regards,
Nikhil

@CaoGiaHieu-dev
Copy link
Contributor Author

Hi @CaoGiaHieu-dev,

Please update the test cases to align with your recent changes. Also, ensure that all applicable checkboxes in the PR list are checked. All test cases must pass before I can merge this PR.

Thanks & regards, Nikhil

@nixrajput Hi . i just repush pr. can you take a look

@nixrajput nixrajput merged commit eabb480 into nixrajput:master Feb 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants