To form vs form for

[jmillxyz]

On master we are failing two tests:

1) test support setting form and field from changeset (new) (LivePhoneTest)
     test/live_phone_test.exs:63
     ** (FunctionClauseError) no function clause matching in PhoenixHTMLHelpers.Form.form_for/4

     The following arguments were given to PhoenixHTMLHelpers.Form.form_for/4:
     
         # 1
         #Ecto.Changeset<action: nil, changes: %{}, errors: [], data: #LivePhoneTestApp.User<>, valid?: true>
     
         # 2
         "/"
     
         # 3
         []
     
         # 4
         []
     
     Attempted function clauses (showing 1 out of 1):
     
         def form_for(form_data, action, options, fun) when is_function(fun, 1)
     
     code: form = form_for(changeset, "/")
     stacktrace:
       (phoenix_html_helpers 1.0.1) lib/phoenix_html_helpers/form.ex:261: PhoenixHTMLHelpers.Form.form_for/4
       test/live_phone_test.exs:70: (test)

.

  2) test support setting form and field from changeset (edit) (LivePhoneTest)
     test/live_phone_test.exs:77
     ** (FunctionClauseError) no function clause matching in PhoenixHTMLHelpers.Form.form_for/4

     The following arguments were given to PhoenixHTMLHelpers.Form.form_for/4:
     
         # 1
         #Ecto.Changeset<action: nil, changes: %{phone: "+16502530000"}, errors: [], data: #LivePhoneTestApp.User<>, valid?: true>
     
         # 2
         "/"
     
         # 3
         []
     
         # 4
         []
     
     Attempted function clauses (showing 1 out of 1):
     
         def form_for(form_data, action, options, fun) when is_function(fun, 1)
     
     code: form = form_for(changeset, "/")
     stacktrace:
       (phoenix_html_helpers 1.0.1) lib/phoenix_html_helpers/form.ex:261: PhoenixHTMLHelpers.Form.form_for/4
       test/live_phone_test.exs:88: (test)

Uses the newer Phoenix.HTML.FormData.to_form/2 as a replacement for Phoenix.HTML.Form.form_for/2.

I'm not completely sure this is a drop-in replacement even though the tests now pass.

[nkezhaya]

Hi @jmillxyz ! Why was the PR closed?

[jmillxyz]

I actually meant to push to a fork, which had already updated some deps. I can reopen with all of those changes!

[nkezhaya]

Sounds good, thanks!

[jmillxyz]

@nkezhaya I was also considering bumping this to 0.8.0 given the number of dependencies that have changed, but defer to you

[jmillxyz]

we can also keep this at 1.12 if needed