Add function for get_card to return 404 on DELETE with bad ID

nkezhaya · Jun 25, 2019 · e73f8aa · e73f8aa
1 parent 7da8c9b
commit e73f8aa
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 11 deletions.
diff --git a/lib/stripe_mock/api.ex b/lib/stripe_mock/api.ex
@@ -15,6 +15,7 @@ defmodule StripeMock.API do
 
   # Cards
   defdelegate list_cards(customer), to: Ops.Card
+  defdelegate get_card(id), to: Ops.Card
   defdelegate get_card!(id), to: Ops.Card
   defdelegate create_card(customer, attrs \\ %{}), to: Ops.Card
   defdelegate create_customer_card_from_source(customer, source, metadata \\ %{}), to: Ops.Card

diff --git a/lib/stripe_mock/api/operations/card.ex b/lib/stripe_mock/api/operations/card.ex
@@ -8,7 +8,7 @@ defmodule StripeMock.API.Operations.Card do
     |> Enum.filter(&(&1.customer_id == customer.id))
   end
 
-  def get_card(id), do: Repo.get(Card, id)
+  def get_card(id), do: Repo.fetch(Card, id)
   def get_card!(id), do: Repo.get!(Card, id)
 
   def create_card(customer, attrs) do

diff --git a/lib/stripe_mock/api/operations/customer.ex b/lib/stripe_mock/api/operations/customer.ex
@@ -6,13 +6,7 @@ defmodule StripeMock.API.Operations.Customer do
     Repo.all(Customer)
   end
 
-  def get_customer(id) do
-    case Repo.get(Customer, id) do
-      nil -> {:error, :not_found}
-      customer -> {:ok, customer}
-    end
-  end
-
+  def get_customer(id), do: Repo.fetch(Customer, id)
   def get_customer!(id), do: Repo.get!(Customer, id)
 
   def create_customer(attrs \\ %{}) do

diff --git a/lib/stripe_mock_web/controllers/source_controller.ex b/lib/stripe_mock_web/controllers/source_controller.ex
@@ -51,9 +51,8 @@ defmodule StripeMockWeb.SourceController do
   end
 
   def delete(conn, %{"id" => id}) do
-    card = API.get_card!(id)
-
-    with {:ok, source} <- API.delete_card(card) do
+    with {:ok, card} <- API.get_card(id),
+         {:ok, source} <- API.delete_card(card) do
       render(conn, "show.json", source: source)
     end
   end