refactor: use Number Badge component from @nl-design-system-candidate #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AdhamAH
force-pushed
the
refactor/number-badge-use-candidate-component
branch
from
48fce13 to
7540c02
Compare
|
@AdhamAH ziet er goed uit! Wat is de reden dat er 2 stories zijn, namelijk:
De Default bevat ook een Value. Is het niet handig om maar van 1 story (Default) uit te gaan? |
|
@Rozerinay het idee dat met value je kan de number geven maar dan de number in je eigen manier presenteren. Dat wat ik heb begrepen. bijv. number is |
|
@AdhamAH aha, goed om te weten. In dat geval kun je beide stories zeker laten staan. |
…nge react component Signed-off-by: Adham AboHasson <[email protected]>
AdhamAH
force-pushed
the
refactor/number-badge-use-candidate-component
branch
from
fe391bc to
9e6e32a
Compare
Signed-off-by: Adham AboHasson <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taak #1090