Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add table tokens #909

Merged
merged 2 commits into from
Jan 15, 2025
Merged

feat: add table tokens #909

merged 2 commits into from
Jan 15, 2025

Conversation

Marwaxhello
Copy link
Contributor

@Marwaxhello Marwaxhello commented Jan 6, 2025

Pull Request Table

In deze PR heb ik table tokens toegevoegd aan de Theme Builder in het Purmerend-thema.

  • table-default
  • table-caption
  • table-header
  • table-header-cell
  • table-footer
  • table-cell
  • table-row

Hoe bepaal ik welke tokens ik moet gebruiken voor elke table-variant? In de documentatie van Utrecht vind je onderaan de pagina een overzicht van alle gebruikte tokens voor een specifieke component, inclusief de verschillende staten van die component. Dit maakt het gemakkelijk om de juiste tokens te identificeren.

@Marwaxhello Marwaxhello requested a review from a team as a code owner January 6, 2025 12:27
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
themes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 7:37pm

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.72%. Comparing base (122219d) to head (4da7045).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
+ Coverage   89.57%   89.72%   +0.15%     
==========================================
  Files          19       19              
  Lines        1343     1363      +20     
  Branches      125      170      +45     
==========================================
+ Hits         1203     1223      +20     
  Misses        140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Robbert
Robbert previously approved these changes Jan 14, 2025
@Robbert Robbert force-pushed the feat/component-story-tokens-table branch from 836d36e to 4da7045 Compare January 14, 2025 19:31
@Robbert Robbert disabled auto-merge January 14, 2025 19:31
@Robbert Robbert enabled auto-merge (squash) January 14, 2025 19:31
@Robbert Robbert disabled auto-merge January 15, 2025 10:19
@Robbert Robbert merged commit 128afc8 into main Jan 15, 2025
5 of 7 checks passed
@Robbert Robbert deleted the feat/component-story-tokens-table branch January 15, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants