Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #89 #105

Merged
merged 5 commits into from
Feb 17, 2025
Merged

Fix #89 #105

merged 5 commits into from
Feb 17, 2025

Conversation

chiscookeke11
Copy link
Contributor

@chiscookeke11 chiscookeke11 commented Feb 16, 2025

close: #89
@Marchand-Nicolas
Please review

Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add the "close: #<issue_number>". I don't know what is this PR for. @chiscookeke11

Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you commited a lot of file. Please remove all the ones not related to the issue

Copy link
Collaborator

@Marchand-Nicolas Marchand-Nicolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good lgtm

@Marchand-Nicolas Marchand-Nicolas merged commit bffc645 into nmalzieu:main Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve help command
2 participants