collapse: add fixup callback restore halfedge data #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In collapseEdgeTriangular, only whole degenerate edges are removed, so we can maintain the implicit sibling property. However, this results in losing at least one halfedge that should remain in the neighborhood after collapse. The lost halfedge is papered over with one of the halfedges from another edge, but this is incorrect if we want to maintain invariants on per-halfedge or per-corner data, such as UV coordinates. This commit provides a callback, fixup, to collapseEdgeTriangular so that the user can restore the lost data
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
In collapseEdgeTriangular, only whole degenerate edges are removed, so we can maintain the implicit sibling property. However, this results in losing at least one halfedge that should remain in the neighborhood after collapse. The lost halfedge is papered over with one of the halfedges from another edge, but this is incorrect if we want to maintain invariants on per-halfedge or per-corner data, such as UV coordinates.
This commit provides a callback, fixup, to collapseEdgeTriangular so that the user can restore the lost data