Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signpost_intrinsic_triangulation: implement equivalentPointOn{Intrinsic,Input} #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kenshi84
Copy link

I played with the signpost intrinsic triangulation demo and realized that equivalentPointOn{Intrinsic,Input} are left unimplemented, so here they are. I needed them for testing my own little research idea that turned out to be doomed, but hopefully someone will find this code useful in the future.

This implementation has a robustness/accuracy issue despite my attempt, as evidenced in the test. In some rare but non-negligible cases, the positional error after going to/from inputMesh and intrinsicMesh gets quite large (more than 50% of the bounding box diagonal). Hopefully someone can fix this bug in the future :)

P.S.
Thank you so much for maintaining this awesome library!

@nmwsharp
Copy link
Owner

Thanks for sharing this, it looks awesome! I really appreciated it.

I haven't gotten a chance to look deeply yet, but it's on my agenda! Hopefully I can get this merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants