Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Service] Add remote service register function @open sesame 08/29 16:31 #321

Merged
merged 2 commits into from
Sep 5, 2023
Merged

[Service] Add remote service register function @open sesame 08/29 16:31 #321

merged 2 commits into from
Sep 5, 2023

Conversation

gichan-jang
Copy link
Member

@gichan-jang gichan-jang commented May 3, 2023 •
edited
Loading

  • Add the function that registers remote service such as NN models, pipeline description and etc.
  • Register pipeline description
  • Add unittest to register pipeline

@taos-ci
Copy link
Collaborator

taos-ci commented May 3, 2023

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #321. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@gichan-jang gichan-jang marked this pull request as draft May 3, 2023 07:53
taos-ci
taos-ci approved these changes May 3, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@gichan-jang gichan-jang force-pushed the remote/launch branch 2 times, most recently from e017584 to 0534c29 Compare June 28, 2023 05:27
@taos-ci
Copy link
Collaborator

taos-ci commented Jun 28, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/321-202306281427340.094131946563721-0534c29a33f1eec63c65bd3687dff2ca38a8566a/.

@gichan-jang gichan-jang force-pushed the remote/launch branch 2 times, most recently from b84a2f7 to 5a35ae2 Compare June 28, 2023 08:13
@gichan-jang gichan-jang marked this pull request as ready for review June 28, 2023 08:14
@gichan-jang gichan-jang requested a review from jijoongmoon as a code owner June 28, 2023 08:14
taos-ci
taos-ci approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

taos-ci
taos-ci approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@gichan-jang gichan-jang force-pushed the remote/launch branch 2 times, most recently from 441c262 to 81d1251 Compare July 3, 2023 08:01
taos-ci
taos-ci approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@taos-ci
Copy link
Collaborator

taos-ci commented Jul 10, 2023

:octocat: cibot: @gichan-jang, c/src/ml-api-service-private.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

taos-ci
taos-ci approved these changes Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@gichan-jang gichan-jang force-pushed the remote/launch branch 2 times, most recently from 4beab4f to a342edb Compare July 11, 2023 04:03
@gichan-jang gichan-jang force-pushed the remote/launch branch 3 times, most recently from dc7266d to 66f0da0 Compare July 21, 2023 02:28
@gichan-jang gichan-jang changed the title [Service] Add remote service register function [Service] Add remote service register function @open sesame 07/21 11:42 Jul 21, 2023
taos-ci
taos-ci approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@taos-ci
Copy link
Collaborator

taos-ci commented Aug 1, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/321-202308011855370.16412091255188-305d4a6f6d898e9356401acdd0db9f8d25949231/.

@gichan-jang gichan-jang changed the title [Service] Add remote service register function @open sesame 07/21 11:42 [Service] Add remote service register function @open sesame 08/02 10:05 Aug 2, 2023
taos-ci
taos-ci approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

songgot
songgot approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

wooksong
wooksong reviewed Aug 9, 2023
View reviewed changes
c/src/ml-api-service-private.h
Comment on lines +96 to +97
* @return @c 0 on Success. Otherwise a negative error value.
* @retval #ML_ERROR_NONE Successful.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: I need to familiarize myself with the Tizen doxygen; thus have a question here. Is line 96 a summary of the return values declaration, and are the following lines for the details?

Copy link
Contributor

@songgot songgot Aug 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order is as follows. @brief, @details, @since_tizen, @remarks, @param, @return, @retval, @pre, @post and @see

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Tizen native API reference guide, return and retval are mandatory tags.

...
  * @return          [Mandatory] Return values
  * @retval          [Mandatory] Meaning of each return value
...

wooksong
wooksong approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@wooksong wooksong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor comments. If you want to merge it, just let me know.

@gichan-jang gichan-jang force-pushed the remote/launch branch 2 times, most recently from 04d68de to 8fecbda Compare August 9, 2023 09:35
@taos-ci
Copy link
Collaborator

taos-ci commented Aug 9, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/321-202308091835400.34059691429138-8fecbdaaa6b4dee45a8cd43efdf1cae3c2f6b19f/.

@taos-ci
Copy link
Collaborator

taos-ci commented Aug 9, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/321-202308091856380.73698997497559-8b36ceac6680fc0cd9f2ecaee28ed94081d419b2/.

@gichan-jang gichan-jang changed the title [Service] Add remote service register function @open sesame 08/02 10:05 [Service] Add remote service register function @open sesame 08/29 16:31 Aug 29, 2023
@taos-ci
Copy link
Collaborator

taos-ci commented Aug 29, 2023

:octocat: cibot: @gichan-jang, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/321-202308291632020.54281902313232-8b36ceac6680fc0cd9f2ecaee28ed94081d419b2/.

taos-ci
taos-ci approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@gichan-jang
[Service] Add remote service register function
1e0fa49 
Add the function that registers remote service such as NN models,
pipeline description and etc.

Signed-off-by: gichan <[email protected]>
Signed-off-by: gichan2-jang <[email protected]>
@gichan-jang
[Service] Register pipeline description
075cfa6 
 - Register pipeline description
 - Add unittest to register pipeline

Signed-off-by: gichan2-jang <[email protected]>
taos-ci
taos-ci approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@again4you again4you merged commit 7923e26 into nnstreamer:main Sep 5, 2023
@gichan-jang gichan-jang deleted the remote/launch branch September 18, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songgot songgot songgot approved these changes

@myungjoo myungjoo myungjoo approved these changes

@wooksong wooksong wooksong approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@taos-ci taos-ci taos-ci approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gichan-jang @taos-ci @myungjoo @wooksong @songgot @jaeyun-jung @again4you