Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] cleanup testcases @open sesame 09/08 17:48 #388

Merged
merged 1 commit into from
Sep 9, 2023
Merged

[Test] cleanup testcases @open sesame 09/08 17:48 #388

merged 1 commit into from
Sep 9, 2023

Conversation

jaeyun-jung
Copy link
Collaborator

Code clean and fix error case, now rank limit of nnstreamer is changed to 16.

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 7, 2023

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #388. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link
Collaborator

taos-ci commented Sep 7, 2023

:octocat: cibot: @jaeyun-jung, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/388-202309071941130.84403705596924-d933cd09f7041c17c39c801b9d85282dadff5598/.

@jaeyun-jung
[Test] cleanup testcases
727f73f 
Code clean and fix error case, now rank limit of nnstreamer is changed to 16.

Signed-off-by: Jaeyun Jung <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Sep 8, 2023

:octocat: cibot: @jaeyun-jung, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/388-202309081144360.53093791007996-727f73fea1ae734d01875d9ab9040131a4c424a5/.

anyj0527
anyj0527 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✔

@again4you again4you changed the title [Test] cleanup testcases [Test] cleanup testcases @open sesame 09/08 Sep 8, 2023
gichan-jang
gichan-jang approved these changes Sep 8, 2023
View reviewed changes
Copy link
Member

@gichan-jang gichan-jang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anyj0527 anyj0527 changed the title [Test] cleanup testcases @open sesame 09/08 [Test] cleanup testcases @open sesame 09/08 17:48 Sep 8, 2023
taos-ci
taos-ci approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

@jaeyun-jung jaeyun-jung merged commit 9d149cb into nnstreamer:main Sep 9, 2023
2 checks passed
@jaeyun-jung jaeyun-jung deleted the test-compare-rank branch September 11, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gichan-jang gichan-jang gichan-jang approved these changes

@taos-ci taos-ci taos-ci approved these changes

@anyj0527 anyj0527 anyj0527 approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

Assignees
No one assigned
Labels
PR/Ready2Go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaeyun-jung @taos-ci @anyj0527 @gichan-jang