Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build/Tizen] dependency of tizen feature #430

Merged
merged 1 commit into from
Jan 3, 2024
Merged

[Build/Tizen] dependency of tizen feature #430

merged 1 commit into from
Jan 3, 2024

Conversation

jaeyun-jung
Copy link
Collaborator

Code clean, update dependency for each tizen features.

@taos-ci
Copy link
Collaborator

taos-ci commented Dec 18, 2023

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #430. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

taos-ci
taos-ci approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

anyj0527
anyj0527 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@anyj0527 anyj0527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM✔ Would this be cherry-picked in the lts branch?

@jaeyun-jung
Copy link
Collaborator Author

Discussion: should we cherry-pick this into lts branch?

@anyj0527
Copy link
Member

Vote to cherry-pick when it's really needed in those branches.

songgot
songgot approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taos-ci
Copy link
Collaborator

taos-ci commented Jan 2, 2024

:octocat: cibot: @jaeyun-jung, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/430-202401021928360.64970111846924-5eaec5fde30868bda8385bbc50837c82defae6c3/.

@taos-ci
Copy link
Collaborator

taos-ci commented Jan 3, 2024

:octocat: cibot: @jaeyun-jung, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/430-202401031446180.047000885009766-aa86c3a1abb0fb3aac7777764eace939e26f2c0c/.

@jaeyun-jung
[Build/Tizen] dependency of tizen feature
c86ba97 
Code clean, update dependency for each tizen features.

Signed-off-by: Jaeyun Jung <[email protected]>
niley7464
niley7464 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@niley7464 niley7464 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

taos-ci
taos-ci approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.

@myungjoo myungjoo merged commit 04d94c4 into nnstreamer:main Jan 3, 2024
2 checks passed
@jaeyun-jung jaeyun-jung deleted the build-tizenfeature branch January 3, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myungjoo myungjoo myungjoo approved these changes

@anyj0527 anyj0527 anyj0527 approved these changes

@songgot songgot songgot approved these changes

@niley7464 niley7464 niley7464 approved these changes

@taos-ci taos-ci taos-ci approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

Assignees
No one assigned
Labels
Discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jaeyun-jung @taos-ci @anyj0527 @myungjoo @songgot @niley7464