Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dist/Tizen] Add omitted build dependency on libtzplatform-config #447

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

wooksong
Copy link
Member

This patch is a trivial bug fix that adds an omitted build dependency on libtzplatform-config to the Tizen RPM spec file.

CC: @jaeyun-jung
Signed-off-by: Wook Song [email protected]

This patch is a trivial bug fix that adds an omitted build dependency
on libtzplatform-config to the Tizen RPM spec file.

Signed-off-by: Wook Song <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Jan 18, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #447. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

This patch appends DB_PATH to the error message for failure in opening
the database file. Note that DB_PATH is not the SQLITE3 database file,
but the path prefix where the file is placed.

CC: Jaeyun Jung <[email protected]>
Signed-off-by: Wook Song <[email protected]>
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wooksong, 💯 All CI checkers are successfully verified. Thanks.

@myungjoo
Copy link
Member

myungjoo commented Jan 18, 2024

If this is required "BuildRequires", how could gbs build the package without it? (CI has been releasing rpms before this PR)

Refer: 04d94c4#diff-60bee65d105d7ac71b2bfd7bddbed9778ea83e3090c658972d0485eebc6047f6

@myungjoo
Copy link
Member

Need a checker that ensures proper DB path setting at build/packaging time.

@myungjoo myungjoo merged commit 298e68f into nnstreamer:main Jan 19, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants