[C-Api/Service] add new API (ML-API ext) #454
Conversation
jaeyun-jung
requested review from
again4you,
myungjoo,
anyj0527,
gichan-jang,
songgot and
jijoongmoon
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #454. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
|
|
cibot:
jaeyun-jung
force-pushed
the
capi-svc-new
branch
from
cf3eb33 to
d182328
Compare
|
|
jaeyun-jung
force-pushed
the
capi-svc-new
branch
from
d182328 to
dfa65ee
Compare
|
|
jaeyun-jung
force-pushed
the
capi-svc-new
branch
from
dfa65ee to
6ef890d
Compare
|
|
jaeyun-jung
force-pushed
the
capi-svc-new
branch
from
6ef890d to
a7062cb
Compare
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
jaeyun-jung
force-pushed
the
capi-svc-new
branch
from
a7062cb to
84a58f6
Compare
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
jaeyun-jung
force-pushed
the
capi-svc-new
branch
from
84a58f6 to
ab1af65
Compare
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
jaeyun-jung
force-pushed
the
capi-svc-new
branch
from
bf08356 to
3382726
Compare
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
jaeyun-jung
force-pushed
the
capi-svc-new
branch
from
3382726 to
b107639
Compare
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
c/include/ml-api-service.h
Outdated
| typedef struct { | ||
| void (*new_data) (ml_service_h handle, const char *name, const ml_tensors_data_h data, void *user_data); /**< Called when new data is processed from machine learning service. */ | ||
| void (*event) (ml_service_h handle, int event, void *event_data, void *user_data); /**< Called when new event is occurred from machine learning service. */ | ||
| } ml_service_callbacks_s; |
There was a problem hiding this comment.
Tizen does not encourage structure-type event callbacks.
It seems that ml_service_callback_s event callbacks can be combined into one like this.
void (*event_callback) (ml_service_h handle, void *event_data, ... );
In the case of void *event_data, how about to use the one with information-handle we released since tizen8.0?
There was a problem hiding this comment.
Agreed, thanks for your suggestion.
We are now preparing Tizen API process as you know.
Let's talk about the event callback and its params on offline discussion, to handle new-data for inference and other events from offloading service.
There was a problem hiding this comment.
I agreed with @niley7464 's suggestion.
Instead of the structure type event callback, how about this unified form?
ml_service can be passed using the user_data, so I think it's not needed.
And let's use information handle considering later scalability
void (*ml_service_event_cb) (int event_type, ml_information_h data, void *user_data);
Reference: Tizen guide
3.5.1 Callback function prototype MUST be based on the template
The template is:
typedef void (*{module_prefix}_{actual_name}_cb)(event_type event, {event details}, void *user_data);
There was a problem hiding this comment.
I updated this PR - added event callback.
Please review the changes again.
jaeyun-jung
force-pushed
the
capi-svc-new
branch
from
b107639 to
e139c11
Compare
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
jaeyun-jung
force-pushed
the
capi-svc-new
branch
from
e139c11 to
708f316
Compare
jaeyun-jung
force-pushed
the
capi-svc-new
branch
4 times, most recently
from
b0d68e8 to
1f3a072
Compare
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
jaeyun-jung
force-pushed
the
capi-svc-new
branch
2 times, most recently
from
c035ed4 to
562f521
Compare
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
jaeyun-jung
force-pushed
the
capi-svc-new
branch
2 times, most recently
from
61afe74 to
e176449
Compare
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
Add new API set for ML service, these functions support constructing new handle from json configuration. - type for ml-service: single, pipeline Signed-off-by: Jaeyun Jung <[email protected]>
jaeyun-jung
force-pushed
the
capi-svc-new
branch
from
e176449 to
f76fade
Compare
There was a problem hiding this comment.
@jaeyun-jung, 💯 All CI checkers are successfully verified. Thanks.
|
Now ready to prepare new API for next Tizen release. |
Add new API set for ML service, these functions support constructing new handle from json configuration.
TODO: need discussion for ml-service remote