Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Example] Training offloading service #330

Merged
merged 1 commit into from
Jun 21, 2024
Merged

[Example] Training offloading service #330

merged 1 commit into from
Jun 21, 2024

Conversation

songgot
Copy link
Contributor

@songgot songgot commented May 9, 2024

This app uses ml service APIs
To test service and develop tensor_trainer and trainer subplugin stop function.

@taos-ci
Copy link
Collaborator

taos-ci commented May 9, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #330. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link
Collaborator

taos-ci commented May 9, 2024

:octocat: cibot: @songgot, Tizen.platform/training_offloading_service/main.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@songgot songgot marked this pull request as draft May 9, 2024 08:10
@songgot songgot force-pushed the training-offloading-services branch from e81ee80 to 04b6f9b Compare May 9, 2024 10:53
@taos-ci
Copy link
Collaborator

taos-ci commented May 9, 2024

:octocat: cibot: @songgot, Tizen.platform/training_offloading_service/main.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@songgot songgot force-pushed the training-offloading-services branch from 04b6f9b to 7667a90 Compare June 19, 2024 10:12
@taos-ci
Copy link
Collaborator

taos-ci commented Jun 19, 2024

:octocat: cibot: @songgot, Tizen.platform/training_offloading_service/main.c does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@songgot songgot marked this pull request as ready for review June 19, 2024 10:13
@songgot songgot force-pushed the training-offloading-services branch from 7667a90 to 71a6d6e Compare June 20, 2024 00:40
taos-ci
taos-ci approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@songgot, 💯 All CI checkers are successfully verified. Thanks.

@songgot songgot force-pushed the training-offloading-services branch from 71a6d6e to 75ad8df Compare June 20, 2024 03:14
@songgot
[Example] Training offloading service example
efd4cad 
- This app uses ml service APIs
- You must run the receiver first with receiver.conf for the sender to work

Signed-off-by: hyunil park <[email protected]>
@songgot songgot force-pushed the training-offloading-services branch from 75ad8df to efd4cad Compare June 20, 2024 03:16
taos-ci
taos-ci approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@songgot, 💯 All CI checkers are successfully verified. Thanks.

jaeyun-jung
jaeyun-jung reviewed Jun 21, 2024
View reviewed changes
Tizen.platform/training_offloading_service/main.c
void
reset_menu_status (void)
{
g_menu_state = CURRENT_STATUS_MAINMENU;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's fix local coding rule - indent using gst-indent tool.

myungjoo
myungjoo reviewed Jun 21, 2024
View reviewed changes
Tizen.platform/training_offloading_service/README.md
@@ -0,0 +1,274 @@
---
title: On device AI training offloading service example
...
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@myungjoo myungjoo merged commit a5e8a20 into nnstreamer:main Jun 21, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taos-ci taos-ci taos-ci approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@myungjoo myungjoo myungjoo approved these changes

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@songgot @taos-ci @myungjoo @jaeyun-jung