Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen/Web] Add ml offloading example using Yolov8 #341

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

niley7464
Copy link
Contributor

This patch adds ml offloading example for Tizen client side.
Yolov8 is used for image classification.

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 18, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #341. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

* This is a sample application of Tizen ML Web APIs.
* If you want to run it on your device, Tizen 8.0 or higher is required.
* `appsrc` and `tensor_query_client` element are used.
* Tflite model is created by this [guide](https://github.com/nnstreamer/nnstreamer-example/tree/main/bash_script/example_yolo#export-to-tflite-and-torchscript-model-1).
Copy link
Collaborator

@jaeyun-jung jaeyun-jung Jun 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converted file is too big (42MB?), how about adding readme in res folder (guide copying model, label, and jpeg image)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. A guide to copy the model before a build,
  2. A script to download the model during a build,
  3. Github-action workflow update to download the model during a build.

We will need (1 or 2) and 3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed tflite model in res directory and added 1,3
Thank you :)

Copy link
Member

@wooksong wooksong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 24, 2024

:octocat: cibot: @niley7464, Tizen.web/ImageClassificationOffloadingYolo/get_tflite_model.py does not include Doxygen tags such as ****. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 24, 2024

This patch adds ml offloading example for Tizen client side.
Yolov8 is used for image classification.

Signed-off-by: Yelin Jeong <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Jun 24, 2024

@taos-ci
Copy link
Collaborator

taos-ci commented Jun 24, 2024

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nnstreamer-example/ci/repo-workers/pr-checker/341-202406241513270.6909921169281-6743a1df8c79d53bd620cc0eb0f7ee8c856efced/report/misspelling_result.txt.

Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niley7464, 💯 All CI checkers are successfully verified. Thanks.

@myungjoo myungjoo merged commit b071207 into nnstreamer:main Jun 29, 2024
30 checks passed
@niley7464 niley7464 deleted the tizen/web/yolo branch July 1, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants